Fix clip to use _InternalFrame.with_new_columns.
#1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Jan 28, 2020
| numeric_columns = [(c, F.when(scol > upper, upper).otherwise(scol).alias(c)) | ||
| for c, scol in numeric_columns] | ||
| numeric_columns = [(idx, (F.when(scol > upper, upper).otherwise(scol) | ||
| .alias(name_like_string(idx)))) |
There was a problem hiding this comment.
Hm .. should we maybe not use alias at all against Spark columns whenever possible?
There was a problem hiding this comment.
Ideally, we can avoid aliasing, but so far we can't avoid column name access so we should have proper names. Otherwise, e.g., if the name becomes something like "xx`yy" by accident, it throws an error since it breaks the naming rule of Spark.
HyukjinKwon
approved these changes
Jan 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
+ Coverage 95.18% 95.18% +<.01%
==========================================
Files 35 35
Lines 7265 7270 +5
==========================================
+ Hits 6915 6920 +5
Misses 350 350
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
DataFrame/Series.clipfunction to use_InternalFrame.with_new_columnsand preserve its index.