Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LocIndexerLike__getitem__. #1152

Merged
merged 2 commits into from
Dec 26, 2019
Merged

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Dec 24, 2019

No description provided.

@ueshin ueshin requested a review from HyukjinKwon December 24, 2019 01:38
@HyukjinKwon
Copy link
Member

Looks good if tests pass

@codecov-io
Copy link

codecov-io commented Dec 26, 2019

Codecov Report

Merging #1152 into master will decrease coverage by 0.07%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
- Coverage   95.24%   95.16%   -0.08%     
==========================================
  Files          35       35              
  Lines        7080     7080              
==========================================
- Hits         6743     6738       -5     
- Misses        337      342       +5
Impacted Files Coverage Δ
databricks/koalas/indexing.py 93.7% <90.32%> (-1.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0541a5d...fc561cc. Read the comment docs.

@ueshin
Copy link
Collaborator Author

ueshin commented Dec 26, 2019

Thanks! I'd merge this now.

@ueshin ueshin merged commit 899b346 into databricks:master Dec 26, 2019
@ueshin ueshin deleted the indexing branch December 26, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants