Skip to content

Commit

Permalink
remove unneeded events
Browse files Browse the repository at this point in the history
  • Loading branch information
benc-db committed Feb 26, 2025
1 parent 88e677d commit b0c2bdf
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 60 deletions.
25 changes: 0 additions & 25 deletions dbt/adapters/databricks/events/connection_events.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,6 @@ def __str__(self) -> str:
return f"{self.description} - {self.message}"


class ConnectionAcquire(ConnectionWrapperEvent):
def __init__(self, description: str, relation_name: Optional[str]):
message = "Acquired connection"

if relation_name:
message += f" for model '{relation_name}'"

super().__init__(description, message)


class ConnectionRelease(ConnectionWrapperEvent):
def __init__(self, description: str):
super().__init__(description, "Released connection")


class ConnectionReset(ConnectionWrapperEvent):
def __init__(self, description: str):
super().__init__(description, "Reset connection handle")
Expand All @@ -63,21 +48,11 @@ def __init__(self, description: str):
super().__init__(description, "Creating connection")


class ConnectionIdleCheck(ConnectionWrapperEvent):
def __init__(self, description: str):
super().__init__(description, "Checking idleness")


class ConnectionIdleClose(ConnectionWrapperEvent):
def __init__(self, description: str):
super().__init__(description, "Recreating due to idleness")


class ConnectionRetrieve(ConnectionWrapperEvent):
def __init__(self, description: str):
super().__init__(description, "Retrieving connection")


class ConnectionCreated(ConnectionWrapperEvent):
def __init__(self, description: str):
super().__init__(description, "Connection created")
35 changes: 0 additions & 35 deletions tests/unit/events/test_connection_events.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from unittest.mock import Mock

from dbt.adapters.databricks.events.connection_events import (
ConnectionAcquire,
ConnectionEvent,
)

Expand All @@ -27,37 +26,3 @@ def test_connection_event__with_id(self):
mock.get_session_id_hex.return_value = "1234"
event = ConnectionTestEvent(mock)
assert str(event) == "Connection(session-id=1234) - This is a test"


class TestConnectionAcquire:
def test_connection_acquire__missing_data(self):
event = ConnectionAcquire(None, None, None, (0, 0))
assert (
str(event)
== "None - Acquired connection on thread (0, 0), using default compute resource"
)

def test_connection_acquire__with_compute_name(self):
event = ConnectionAcquire(None, None, "Eniac", (0, 0))
assert (
str(event)
== "None - Acquired connection on thread (0, 0), using compute resource 'Eniac'"
)

def test_connection_acquire__with_nonmodel_node(self):
event = ConnectionAcquire(None, Mock([]), None, (0, 0))
assert (
str(event)
== "None - Acquired connection on thread (0, 0), using default compute resource"
" for model '[Unknown]'"
)

def test_connection_acquire__with_everything(self):
model = Mock()
model.relation_name = "MyModel"
event = ConnectionAcquire("Connection", model, "Eniac", (0, 0))
assert (
str(event)
== "Connection - Acquired connection on thread (0, 0), using compute resource 'Eniac'"
" for model 'MyModel'"
)

0 comments on commit b0c2bdf

Please sign in to comment.