Skip to content

Fix log error in oauth.py #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kravets-levko merged 4 commits into from
May 29, 2024
Merged

Fix log error in oauth.py #269

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fb6aa8
Duplicate of applicable change from #93
Nov 1, 2023
eadfd5c
Update changelog
Nov 1, 2023
40d17c7
Merge branch 'main' into fix-oauth-log
kravets-levko May 29, 2024
72fd790
Fix after merge
kravets-levko May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Add integration tests for Databricks UC Volumes ingestion queries
- Add `_retry_max_redirects` config
- Enable cloud fetch by default. To disable, set `use_cloud_fetch=False` when building `databricks.sql.client`.
- Fix: our logger would raise an uncaught exception under certain oauth error conditions

## 2.9.3 (2023-08-24)

Expand Down
2 changes: 1 addition & 1 deletion src/databricks/sql/auth/oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def __get_authorization_code(self, client, auth_url, scope, state, challenge):
logger.info(f"Port {port} is in use")
last_error = e
except Exception as e:
logger.error("unexpected error", e)
logger.error("unexpected error: %s", e)
if self.redirect_port is None:
logger.error(
f"Tried all the ports {self.port_range} for oauth redirect, but can't find free port"
Expand Down