Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve semantics for listing methods #569

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Improve semantics for listing methods #569

wants to merge 9 commits into from
+642 −135

Commits on Aug 10, 2023

  1. Improve semantics for listing methods 

    This PR moves listing requests to an `ListXXXInternal` entity, which keeps all the low-level pagination request fields, like `offset`, `limit`, `token`, `page`. Original entity keeps all of the fields, except pagination-related. This allows to mitigate a common confusion, where users supply `limit` for the iterator and it acting only a _result page limit_, not the _max number of results_.
    @nfx
    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    af0066e View commit details
    Browse the repository at this point in the history

  2. make progress

    @nfx
    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e2f4cee View commit details
    Browse the repository at this point in the history

  3. make progress

    @nfx
    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0b123e0 View commit details
    Browse the repository at this point in the history

  4. make things work

    @nfx
    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    2973071 View commit details
    Browse the repository at this point in the history

  5. fmt

    @nfx
    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    2c4f8c9 View commit details
    Browse the repository at this point in the history

  6. rename listing to request

    @nfx
    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    48d994c View commit details
    Browse the repository at this point in the history

  7. panic on incorrect types

    @nfx
    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b55e389 View commit details
    Browse the repository at this point in the history

  8. camel

    @nfx
    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    fa68d8c View commit details
    Browse the repository at this point in the history

  9. refactored templates

    @nfx
    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    128d1f6 View commit details
    Browse the repository at this point in the history