Add Lakeflow template#2959
Merged
Merged
Conversation
fjakobs
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
fjakobs
requested review from
lennartkats-db
and removed request for
andrewnester,
anton-107 and
denik
fjakobs
commented
May 30, 2025
fjakobs
force-pushed
the
lakeflow-template
branch
from
08a9131 to
5e6be26
Compare
Contributor
lennartkats-db
left a comment
lennartkats-db
left a comment
There was a problem hiding this comment.
Awesome! I added some quick initial comments
Contributor
|
Can you add acceptance test here? https://github.com/databricks/cli/tree/main/acceptance/bundle/templates For some templates we only do init + validate in local mode, for other templates (default-python) we do init+validate+deploy against local fake server and against cloud env. We also include materialized template there so you can see what you get. |
fjakobs
force-pushed
the
lakeflow-template
branch
from
7f5ec1f to
2bcd816
Compare
lennartkats-db
requested changes
May 30, 2025
| "editor.defaultFormatter": "ms-python.black-formatter", | ||
| "editor.formatOnSave": true, | ||
| }, | ||
| } |
Contributor
There was a problem hiding this comment.
Should we add "python.analysis.typeCheckingMode": "basic" here? Or, probably better, revisit that question later?
Contributor
Author
There was a problem hiding this comment.
I'd prefer to defer that decision
Contributor
Author
|
@denik I've added the acceptance tests |
fjakobs
force-pushed
the
lakeflow-template
branch
from
a853d0e to
2959c84
Compare
pietern
reviewed
Jun 2, 2025
| # Preamble | ||
|
|
||
| This file only template directives; it is skipped for the actual output. | ||
| This file only contains template directives; it is skipped for the actual output. |
Contributor
There was a problem hiding this comment.
Can you file a separate PR for this?
| {{$isSQL := eq .language "sql"}} | ||
|
|
||
| {{if $isSQL}} | ||
| {{skip "{{.project_name}}/resources/{{.project_name}}_pipeline/utilities/utils.py"}} |
Contributor
There was a problem hiding this comment.
The default pipeline name is clunky. Can this be static instead?
Contributor
Author
There was a problem hiding this comment.
We had a discussion about this last Friday. I'll send you the pointer.
pietern
reviewed
Jun 2, 2025
pietern
reviewed
Jun 2, 2025
pietern
approved these changes
Jun 2, 2025
lennartkats-db
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add Lakeflow template based on the new Pipeline folder structure and leveraging the new
globandroot_pathproperties.Why
Tests