Skip to content

Resolve variables in a loop #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 9 commits into from
Jan 16, 2025
Merged

Resolve variables in a loop #2164

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cefd5bf
Resolve variables in a loop
denik Jan 16, 2025
154a4bf
use bool for hasUpdates instead of int
denik Jan 16, 2025
d7dba5e
add a test for cycle
denik Jan 16, 2025
2aae759
add a test for complex-cycle; reduce rounds to 12
denik Jan 16, 2025
9d91d72
add another cycle test with one variable
denik Jan 16, 2025
c3ac311
fix maxRounds check
denik Jan 16, 2025
d2c79c8
Reduce rounds to 11. Add a comment about timings.
denik Jan 16, 2025
56267a7
add acceptance/bundle/variables/complex-cross-ref (it passes on main,…
denik Jan 16, 2025
1e37279
fix tests 12 -> 11
denik Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions acceptance/bundle/variables/cycle/databricks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
bundle:
name: cycle

variables:
a:

@andrewnester andrewnester Jan 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant a deeper level of nesting for cycle :) something like


variables:
  a:
    default: ${var.complex.a}
  b:
    default: ${var.a}
  c: 
    default: ${var.b}
  complex:
    default: 
        a: ${var.c}
        b: foo

default: ${var.b}
b:
default: ${var.a}
14 changes: 14 additions & 0 deletions acceptance/bundle/variables/cycle/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Error: cycle detected in field resolution: variables.a.default -> var.b -> var.a -> var.b

{
"a": {
"default": "${var.b}",
"value": "${var.b}"
},
"b": {
"default": "${var.a}",
"value": "${var.a}"
}
}

Exit code: 1
1 change: 1 addition & 0 deletions acceptance/bundle/variables/cycle/script
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
$CLI bundle validate -o json | jq .variables