Skip to content

Assert tokens are redacted in origin URL when username is not specified #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyas-goenka merged 3 commits into from
Sep 23, 2024
Merged

Assert tokens are redacted in origin URL when username is not specified #1785

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ead24d
Assert tokens are redacted in origin URL when username is not specified
shreyas-goenka Sep 23, 2024
4ab039b
remove azure tests
shreyas-goenka Sep 23, 2024
e889d48
clarify
shreyas-goenka Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions libs/git/repository_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,23 @@ func TestRepositoryGitConfigWhenNotARepo(t *testing.T) {
}

func TestRepositoryOriginUrlRemovesUserCreds(t *testing.T) {
repo := newTestRepository(t)
repo.addOriginUrl("https://username:token@github.com/databricks/foobar.git")
repo.assertOriginUrl("https://github.com/databricks/foobar.git")
tcases := []struct {
url string
expected string
}{
{
url: "https://username:token@github.com/databricks/foobar.git",
expected: "https://github.com/databricks/foobar.git",
},
{
url: "https://token@github.com/databricks/foobar.git",
Comment thread
shreyas-goenka marked this conversation as resolved.
expected: "https://github.com/databricks/foobar.git",
},
}

for _, tc := range tcases {
repo := newTestRepository(t)
repo.addOriginUrl(tc.url)
repo.assertOriginUrl(tc.expected)
}
}