Skip to content

fix: builder&concat container jentry len fix #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2024
Merged

fix: builder&concat container jentry len fix #43

merged 2 commits into from
Jan 7, 2024

Conversation

@akoshchiy
Copy link
Contributor

@akoshchiy akoshchiy commented Jan 4, 2024 •
edited
Loading

Fix jentry length encoding for containers in concat and builder.

Discovered while testing in databend. Seems that the encoded len in the container jentry is not using in serde. So the previous tests were green :)

@akoshchiy akoshchiy marked this pull request as ready for review January 4, 2024 21:34
@akoshchiy akoshchiy marked this pull request as draft January 5, 2024 13:23
@akoshchiy akoshchiy changed the title fix: builder container jentry len fix fix: builder&concat container jentry len fix Jan 5, 2024
@akoshchiy akoshchiy marked this pull request as ready for review January 5, 2024 14:05
@BohuTANG BohuTANG requested a review from b41sh January 7, 2024 01:14
@akoshchiy akoshchiy mentioned this pull request Jan 7, 2024
Merged
11 tasks
@b41sh b41sh merged commit a0669bf into databendlabs:main Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b41sh b41sh b41sh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akoshchiy @b41sh