Skip to content

Conversation

@akoshchiy
Copy link
Contributor

Added exists_any_keys & exists_all_keys (supporting operators ?|, ?, ?& for databendlabs/databend#11270).

Searching object key doesn't seems to be optimal. We can optimize it to logarithmic via bsearch, but we should add offset-encoding support at first (like postgres does).

@akoshchiy akoshchiy marked this pull request as ready for review October 31, 2023 17:53
@b41sh b41sh self-requested a review November 1, 2023 03:39
@b41sh
Copy link
Member

b41sh commented Nov 1, 2023

Added exists_any_keys & exists_all_keys (supporting operators ?|, ?, ?& for datafuselabs/databend#11270).

Searching object key doesn't seems to be optimal. We can optimize it to logarithmic via bsearch, but we should add offset-encoding support at first (like postgres does).

Yes, it is true that key searches perform poorly, and we can optimize it later on

Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b41sh b41sh merged commit d11c9a9 into databendlabs:main Nov 1, 2023
@akoshchiy akoshchiy deleted the 11270-keys-exists-api branch November 6, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants