Skip to content

Conversation

@akoshchiy
Copy link
Contributor

Added to_pretty_string, which is necessary for databendlabs/databend#11270.

@akoshchiy
Copy link
Contributor Author

@sundy-li @b41sh PTAL.

@BohuTANG BohuTANG requested a review from b41sh August 20, 2023 01:37
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for the contribution @akoshchiy

@b41sh
Copy link
Member

b41sh commented Aug 21, 2023

error: this expression creates a reference which is immediately dereferenced by the compiler
    --> src/functions.rs:1031:17
     |
1031 |                 &pretty_opts,
     |                 ^^^^^^^^^^^^ help: change this to: `pretty_opts`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
     = note: `-D clippy::needless-borrow` implied by `-D warnings`

error: calling `push_str()` using a single-character string literal
    --> src/functions.rs:1064:17
     |
1064 |                 json.push_str("\n");
     |                 ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `json.push('\n')`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
     = note: `-D clippy::single-char-add-str` implied by `-D warnings`

error: calling `push_str()` using a single-character string literal
    --> src/functions.rs:1115:17
     |
1115 |                 json.push_str("\n");
     |                 ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `json.push('\n')`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str

error: could not compile `jsonb` due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `jsonb` due to 3 previous errors

please fix the Clippy error @akoshchiy

@akoshchiy
Copy link
Contributor Author

@b41sh done :)

@b41sh b41sh merged commit cb4b1eb into databendlabs:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants