Skip to content

chore(deps): bump deps#6117

Merged
mergify[bot] merged 6 commits intodatabendlabs:mainfrom
PsiACE:bump-6m
Jun 22, 2022
Merged

chore(deps): bump deps#6117
mergify[bot] merged 6 commits intodatabendlabs:mainfrom
PsiACE:bump-6m

Conversation

@PsiACE
Copy link
Contributor

@PsiACE PsiACE commented Jun 21, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Bump most dependencies

Reduce the number of dependencies to be built by about 30

build: 795 -> 767
build-release: 986 -> 957
test: 883 -> 852
lint: 1118 -> 1086

Changelog

  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #issue

@vercel
Copy link

vercel bot commented Jun 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 2:09AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@PsiACE PsiACE marked this pull request as ready for review June 21, 2022 14:22
@Xuanwo
Copy link
Member

Xuanwo commented Jun 21, 2022

Maybe we still need to update the Cargo.lock.

let mut h = PROMETHEUS_HANDLE.as_ref().write();
*h = Some(recorder.handle());
metrics::clear_recorder();
unsafe {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need unsafe here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metrics::clear_recorder(); was removed from metrics (technically just marked unsafe and hidden from docs) due to being dangerous to use.

There is a potential data race here, and I think we can open an issue and try to fix it.

@ygf11
Copy link
Contributor

ygf11 commented Jun 22, 2022

Wow, nice work!

I am curious, how you find these crates which need dump and also the target versions?

@PsiACE
Copy link
Contributor Author

PsiACE commented Jun 22, 2022

how you find these crates which need dump and also the target versions?

I have written such a document https://databend.rs/doc/faq/routine-maintenance

The steps are simple and only require some manual tweaks.

@ygf11
Copy link
Contributor

ygf11 commented Jun 22, 2022

have written such a document https://databend.rs/doc/faq/routine-maintenance

Thanks, learn much :)

@mergify mergify bot merged commit 28eb03f into databendlabs:main Jun 22, 2022
@PsiACE PsiACE deleted the bump-6m branch June 23, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants