Skip to content

feat: add probe ratio threshold setting #19083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
SkyFan2002 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: add probe ratio threshold setting #19083

SkyFan2002 wants to merge 3 commits into from
+292 −21

Conversation

@SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Dec 9, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Added a join_runtime_filter_probe_ratio_threshold setting (default 3) with getter so the probe/build ratio gate is user-configurable.
  • Propagated this threshold through runtime-filter planning and execution paths (new hash join, legacy pipelines, and converter) so filters are enabled only when a probe target’s estimated rows exceed the ratio.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@SkyFan2002 SkyFan2002 added the ci-cloud Build docker image for cloud test label Dec 9, 2025
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Docker Image for PR

  • tag: pr-19083-d9c90af-1765277242

note: this image tag is only available for internal use.

@SkyFan2002
Merge remote-tracking branch 'upstream/main' into rf_1209
fde83ab 
# Conflicts:
#	src/query/service/src/pipelines/processors/transforms/hash_join/runtime_filter/interface.rs
#	src/query/service/src/pipelines/processors/transforms/new_hash_join/memory/inner_join.rs
#	src/query/service/src/pipelines/processors/transforms/new_hash_join/runtime_filter.rs
@SkyFan2002
refactor
6efcc72
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

🤖 CI Job Analysis

Workflow: 20071372892

📊 Summary

  • Total Jobs: 83
  • Failed Jobs: 1
  • Retryable: 0
  • Code Issues: 1

❌ NO RETRY NEEDED

All failures appear to be code/test issues requiring manual fixes.

🔍 Job Details

  • ❌ linux / test_unit: Not retryable (Code/Test)
🤖 About

Automated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SkyFan2002