-
Notifications
You must be signed in to change notification settings - Fork 837
refactor: stream spill triggering for partial aggregation #18943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
359c3c6 to
b4dc485
Compare
67add26 to
5e6d151
Compare
Docker Image for PR
|
Docker Image for PR
|
Docker Image for PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
...lines/processors/transforms/aggregator/new_aggregate/new_transform_aggregate_spill_writer.rs
Show resolved
Hide resolved
.../pipelines/processors/transforms/aggregator/serde/transform_exchange_aggregate_serializer.rs
Show resolved
Hide resolved
Docker Image for PR
|
…tabendlabs#18943)" This reverts commit 4f03b8d.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
WIP
part of #18906
Replace per-block “spill immediately” with a batch/stream policy so spilled fragments are reasonably sized. This reduces tiny files and I/O amplification.
Tests
Type of change
This change is