-
Notifications
You must be signed in to change notification settings - Fork 835
feat: improve runtime filter [Part 1] #18893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4707bac to
a8bd6cb
Compare
Docker Image for PR
|
Docker Image for PR
|
Docker Image for PR
|
Docker Image for PR
|
Docker Image for PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/query/service/src/pipelines/processors/transforms/hash_join/runtime_filter/convert.rs
Outdated
Show resolved
Hide resolved
|
Marked as draft due to some tests failing. |
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR improves the runtime filter mechanism with several optimizations to enhance join performance and reduce unnecessary filtering overhead.
Changes
Push down runtime filters to probe key equivalence classes - Extends runtime filter coverage by propagating filters through equivalent expressions, enabling more join scenarios to benefit from early filtering. Performance Optimization: Propagate Runtime Filters Through Join Equivalence Classes #18857
Scan waits for runtime filter construction - Synchronizes table scans with runtime filter generation to ensure filters are applied before reading data, maximizing filtering effectiveness.
Runtime-based filter construction decision - Dynamically determines whether to build runtime filters based on runtime statistics, avoiding overhead when filters provide minimal benefit.
Performance
TPC-DS SF100, Large Warehouse:
Tests
Type of change
This change is