Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): aviod building TransformSortMergeLimit with a big number limit #17339

Merged
merged 6 commits into from
Jan 22, 2025
Merged

fix(query): aviod building TransformSortMergeLimit with a big number limit #17339

merged 6 commits into from
Jan 22, 2025

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Jan 20, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 20, 2025
@forsaken628 forsaken628 requested review from b41sh and sundy-li January 20, 2025 08:45
@sundy-li sundy-li enabled auto-merge January 21, 2025 07:29
@sundy-li sundy-li added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@sundy-li sundy-li merged commit 0154424 into databendlabs:main Jan 22, 2025
70 checks passed
@forsaken628 forsaken628 deleted the sort-limit-oom branch January 22, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: limit with a big number cause memory allocation panic
3 participants
@forsaken628 @b41sh @sundy-li