Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused _row_number #17336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove unused _row_number #17336

wants to merge 1 commit into from
+0 −15

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Jan 20, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

remove unused codes

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhyass zhyass requested review from sundy-li and Dousir9 January 20, 2025 03:51
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 20, 2025
@zhyass zhyass changed the title chore: remove unused codes chore: remove unused _row_number Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li Awaiting requested review from sundy-li

@Dousir9 Dousir9 Awaiting requested review from Dousir9

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhyass