Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): add check window frame #17316

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 17, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): add check window frame
fixes: #17294 #17298

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 17, 2025
@sundy-li sundy-li requested review from TCeason and b41sh January 17, 2025 07:07
@sundy-li sundy-li added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@sundy-li sundy-li enabled auto-merge January 18, 2025 00:03
@sundy-li sundy-li added this pull request to the merge queue Jan 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 18, 2025
@b41sh b41sh added this pull request to the merge queue Jan 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2025
@sundy-li sundy-li merged commit 84ebeb8 into databendlabs:main Jan 21, 2025
70 checks passed
@sundy-li sundy-li deleted the window-frame branch January 21, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: window function entered unreachable code
3 participants