Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use full path as cache key for parquet meta. #17313

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: use full path as cache key for parquet meta. #17313

merged 1 commit into from
Jan 17, 2025

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jan 17, 2025 •
edited by BohuTANG
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun requested a review from sundy-li January 17, 2025 00:22
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 17, 2025
@youngsofun youngsofun requested a review from dantengsky January 17, 2025 00:24
@youngsofun youngsofun added this pull request to the merge queue Jan 17, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 17, 2025
@BohuTANG BohuTANG merged commit e6e3aec into databendlabs:main Jan 17, 2025
79 of 82 checks passed
@BohuTANG
Copy link
Member

To close multiple issues with one PR after it merges, use:

- fixes: issue-1
- fixes: issue-2
- fixes: ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@dantengsky dantengsky Awaiting requested review from dantengsky

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: miss use of caching when read parquet meta in copy_from_table bug: Regression on COPY INTO
3 participants
@youngsofun @BohuTANG @sundy-li