Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): improve fuse row fetch, use accumulating #17309

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 16, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

improve fuse row fetch, use accumulating to reduce row fetch io times

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

random hits data on 2 local nodes

select *  from hits where UserID % 10000 = 1 limit 100;    1.5s --> 0.2s

This change is Reviewable

@sundy-li sundy-li requested a review from zhang2014 January 16, 2025 13:20
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 16, 2025
@sundy-li sundy-li added the ci-cloud Build docker image for cloud test label Jan 16, 2025
Copy link
Contributor

Docker Image for PR

  • tag: pr-17309-c1fb432-1737036076

note: this image tag is only available for internal use,
please check the internal doc for more details.

@sundy-li sundy-li removed the ci-cloud Build docker image for cloud test label Jan 17, 2025
@sundy-li sundy-li enabled auto-merge January 17, 2025 01:09
@sundy-li sundy-li added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@BohuTANG BohuTANG merged commit 37d96b2 into databendlabs:main Jan 17, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants