Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make error message of conflicting transactions more user-friendly #17307

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Jan 16, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

revelant issue: #17306

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 16, 2025
Copy link

what-the-diff bot commented Jan 16, 2025

PR Summary

  • Improved System Transparency
    The team has added a new logging feature to record issues that may occur during the final steps of processing transactions. This will help us quickly identify and rectify any potential bottlenecks or conflicts.

  • Better Error Communication in Catalog Updates
    They have fine-tuned the system's error messages when updating multiple-table metadata in the Catalog. Now, it can precisely communicate any issues related to conflicting table IDs, which could happen when multiple transactions are happening simultaneously.

  • Refined Error Management During Transaction Finalization
    The process of transaction finalization has been improved as well. Previously, if there were version mismatches in tables, it could lead to transaction failures. Now, the system will provide more detailed information about such issues to help diagnose, and subsequently resolve, these more swiftly.

@SkyFan2002 SkyFan2002 requested a review from dantengsky January 16, 2025 10:41
@dantengsky dantengsky added this pull request to the merge queue Jan 16, 2025
Merged via the queue into databendlabs:main with commit 94c96f9 Jan 16, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants