Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(query): introduce udf runtime pool #17304

Merged
merged 5 commits into from
Jan 17, 2025
Merged

refactor(query): introduce udf runtime pool #17304

merged 5 commits into from
Jan 17, 2025

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Jan 16, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jan 16, 2025
@sundy-li sundy-li requested a review from b41sh January 16, 2025 12:19
@sundy-li
Copy link
Member

sundy-li commented Jan 16, 2025 •
edited
Loading

Almost LGTM.

Need shell tests that execute 4 sqls with python/js udf on parallel.

20+_others/20_0023_udf_script.sh

@forsaken628 forsaken628 added this pull request to the merge queue Jan 17, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 17, 2025
@BohuTANG BohuTANG merged commit 248ec52 into databendlabs:main Jan 17, 2025
76 checks passed
@BohuTANG
Copy link
Member

Need backport to 680?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor udf script
4 participants
@forsaken628 @sundy-li @BohuTANG @b41sh