feat(metrics): display scan rows/bytes, write rows/bytes in global counter metrics #17266
+120
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
|
The metrics recorder has some locks, let's run the performance tests. |
zhang2014
reviewed
Jan 14, 2025
| } | ||
| } | ||
|
|
||
| pub fn incr(&self, progress_values: &ProgressValues) { | ||
| self.rows.fetch_add(progress_values.rows, Ordering::Relaxed); | ||
| self.bytes | ||
| .fetch_add(progress_values.bytes, Ordering::Relaxed); | ||
| if let Some(hook) = &self.hook { |
There was a problem hiding this comment.
this might result in double counting if cluster mode.
There was a problem hiding this comment.
can you help explain more about this?
Docker Image for PR
|
|
close this due to performance decrease, let me try another with prometheus' collector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
currently we've tracked the scan rows/bytes, write rows/bytes progress value in query stats. and collected them into metrics in query_finished.
but this have an issue like, given a COPY statement which executed for 10 hours. this
databend_query_scan_rowswill kept to be zero during the executation, can not reflect the executing progress in metrics.this pr add a hook on the
Progressstruct to increment the global metrics as well as the local stats.Tests
Type of change
This change is