refactor: try drop old udf - DON'T MERGE

[TCeason]

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

In earlier version, udf serialize as json. In the current version, we can not drop/list these udfs.

show user functions;
2001=>InvalidReply: source:(PbDecodeError: failed to decode Protobuf message: buffer underflow; when:(decode value of __fd_udfs/tn3ftqihs/plusp)) while list UDFs

drop function IF EXISTS plusp;
2001=>InvalidReply: source:(PbDecodeError: failed to decode Protobuf message: buffer underflow; when:(decode value of __fd_udfs/tn3ftqihs/plusp))

So if drop udf return err, we directly drop the kv.

• fixes: bug: failed to user functions #17174

Tests

• Unit Test
• Logic Test
• Benchmark Test
• No Test - Explain why

Type of change

• Bug Fix (non-breaking change which fixes an issue)
• New Feature (non-breaking change which adds functionality)
• Breaking Change (fix or feature that could cause existing functionality not to work as expected)
• Documentation Update
• Refactoring
• Performance Improvement
• Other (please describe):

---

This change is 

[drmingdrmer]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TCeason)

---

src/query/management/src/udf/udf_mgr.rs line 168 at r1 (raw file):

        } else {
            self.try_drop_old_udf(udf_name).await?;
            Ok(None)

To this method, Ok(None) means nothing is removed.

If it's meant to remove an obsolete udf, the caller should call try_drop_old_udf() directly, instead of delegate to try_drop_old_udf() in this method.

Code quote:

            self.try_drop_old_udf(udf_name).await?;
            Ok(None)

[TCeason]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TCeason)

src/query/management/src/udf/udf_mgr.rs line 168 at r1 (raw file):

        } else {
            self.try_drop_old_udf(udf_name).await?;
            Ok(None)

To this method, Ok(None) means nothing is removed.

If it's meant to remove an obsolete udf, the caller should call try_drop_old_udf() directly, instead of delegate to try_drop_old_udf() in this method.

Code quote:

            self.try_drop_old_udf(udf_name).await?;
            Ok(None)

Get so after we drop the old udf we should remove this logic

[BohuTANG]

Need a log here to know which old udf is dropped.

[github-actions]

Docker Image for PR

• tag: pr-17264-4b65245-1736822418

note: this image tag is only available for internal use,
please check the internal doc for more details.

[github-actions]

Docker Image for PR

• tag: pr-17264-722e28e-1736846581

note: this image tag is only available for internal use,
please check the internal doc for more details.

[github-actions]

Docker Image for PR

• tag: pr-17264-4a9ec00-1736851907

note: this image tag is only available for internal use,
please check the internal doc for more details.

[TCeason]

Already normal. Close pr.