Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: object warehouse support rbac #17262

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: object warehouse support rbac #17262

wants to merge 4 commits into from

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jan 13, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

DRAFT

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason requested a review from drmingdrmer as a code owner January 13, 2025 08:11
@TCeason TCeason marked this pull request as draft January 13, 2025 08:11
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 13, 2025
@TCeason TCeason force-pushed the warehouse_rbac branch 2 times, most recently from 61ebeb4 to f6f2812 Compare January 13, 2025 08:14
@TCeason
Copy link
Collaborator Author

TCeason commented Jan 13, 2025

Need to add compatibility tests.

@BohuTANG
Copy link
Member

Does this affect the cloud warehouse's operations?

drmingdrmer
drmingdrmer approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TCeason)

@TCeason
Copy link
Collaborator Author

TCeason commented Jan 13, 2025

Does this affect the cloud warehouse's operations?

No. Now it only control warehouse operator plan. Cloud warehouse need to support these plan.

@TCeason TCeason force-pushed the warehouse_rbac branch 3 times, most recently from 62afcd1 to 7640dfa Compare January 13, 2025 13:31
drmingdrmer
drmingdrmer approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TCeason)

@TCeason TCeason force-pushed the warehouse_rbac branch 3 times, most recently from a4bbacd to af24458 Compare January 15, 2025 02:56
@TCeason TCeason added the ci-cloud Build docker image for cloud test label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17262-d6d5d0a-1736917932

note: this image tag is only available for internal use,
please check the internal doc for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support RBAC for warehouse
3 participants
@TCeason @BohuTANG @drmingdrmer