Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix lazy columns missed in constant table scan #17258

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

Damon07
Copy link
Contributor

@Damon07 Damon07 commented Jan 13, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The build_limit method of PhysicalPlanBuilder excludes lazy columns and adds them back in RowFetch, including the row_id_col in the table scan but not in the constant table scan. So, I directly add the lazy columns to the output_schema of the constant table scan.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 13, 2025
@b41sh b41sh self-requested a review January 13, 2025 08:11
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Damon07 Thanks for your contribution.

@b41sh b41sh added this pull request to the merge queue Jan 14, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 14, 2025
@BohuTANG BohuTANG merged commit 5b372c1 into databendlabs:main Jan 14, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: order by and limit with empty scan can't find the column
3 participants