Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): hash table scatter will always send agg meta #17245

Merged
merged 14 commits into from
Jan 13, 2025

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 10, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): hash table scatter will always send agg meta

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 10, 2025
@sundy-li sundy-li added the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Jan 12, 2025
Copy link
Contributor

Docker Image for PR

  • tag: pr-17245-b590f09-1736696267

note: this image tag is only available for internal use,
please check the internal doc for more details.

@sundy-li sundy-li requested a review from zhang2014 January 13, 2025 02:52
@sundy-li sundy-li marked this pull request as ready for review January 13, 2025 02:52
@sundy-li sundy-li added this pull request to the merge queue Jan 13, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 13, 2025
@BohuTANG BohuTANG merged commit 61e962e into databendlabs:main Jan 13, 2025
88 checks passed
sundy-li added a commit to sundy-li/databend that referenced this pull request Jan 13, 2025
…s#17245)

* fix(query): hash table scatter will always send agg meta

* fix(query): hash table scatter will always send agg meta

* fix(query): z

* fix(query): z

* update

* update

* update

* z

* z

* z

* z

* z

* z

* z
zhang2014 pushed a commit that referenced this pull request Jan 14, 2025
…7267)

* fix(query): hash table scatter will always send agg meta (#17245)

* fix(query): hash table scatter will always send agg meta

* fix(query): hash table scatter will always send agg meta

* fix(query): z

* fix(query): z

* update

* update

* update

* z

* z

* z

* z

* z

* z

* z

* fix(query): increase state_rows in copy agg state rows (#17252)

* fix(query): increase state_rows in copy agg state rows

* fix(query): increase state_rows in copy agg state rows

* fix(query): increase state_rows in copy agg state rows

* Revert "fix(query): increase state_rows in copy agg state rows (#17252)"

This reverts commit 7af80b1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants