Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable sort spill in recluster #17236

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: enable sort spill in recluster #17236

wants to merge 6 commits into from
+67 −44

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Jan 9, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. enable sort spill in alter recluster to avoid oom
  2. fix hilbert clustering with quoted key bug.
  3. Adjusts the Transform Compact operator to exclude null columns when calculating block memory size.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhyass zhyass marked this pull request as draft January 9, 2025 14:34
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 9, 2025
@zhyass zhyass added ci-cloud Build docker image for cloud test and removed pr-chore this PR only has small changes that no need to record, like coding styles. labels Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Docker Image for PR

  • tag: pr-17236-7519169-1736435293

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 10, 2025
@zhyass zhyass force-pushed the feat_fix branch 2 times, most recently from 1351e6c to 558acd0 Compare January 15, 2025 12:22
@zhyass zhyass added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17236-6e2f454-1736993849

note: this image tag is only available for internal use,
please check the internal doc for more details.

@zhyass zhyass added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17236-698deda-1737006398

note: this image tag is only available for internal use,
please check the internal doc for more details.

@zhyass zhyass added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17236-0e79559-1737114445

note: this image tag is only available for internal use,
please check the internal doc for more details.

@zhyass zhyass force-pushed the feat_fix branch 2 times, most recently from 7113899 to eeec7ca Compare January 20, 2025 03:47
@zhyass zhyass marked this pull request as ready for review January 20, 2025 03:57
@zhyass zhyass requested review from sundy-li and dantengsky January 20, 2025 03:57
@zhyass zhyass force-pushed the feat_fix branch 2 times, most recently from 227def7 to 568c10a Compare January 20, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li Awaiting requested review from sundy-li

@dantengsky dantengsky Awaiting requested review from dantengsky

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhyass