Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use opendal to implement recover object instead #17165

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 3, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR will opendal to implement recover object. This implement ensures that all our storage operations are using the same http client, avoiding any possible http configuration related issues.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jan 3, 2025
@Xuanwo Xuanwo requested a review from dantengsky January 3, 2025 13:57
src/query/ee/src/fail_safe/handler.rs Outdated Show resolved Hide resolved
src/query/ee/src/fail_safe/handler.rs Outdated Show resolved Hide resolved
Xuanwo added 2 commits January 6, 2025 11:59
Signed-off-by: Xuanwo <[email protected]>
…er-object' into opendal-based-recover-object
@Xuanwo Xuanwo requested a review from dantengsky January 6, 2025 04:00
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 6, 2025

All comments have been addressed, PTAL @dantengsky, thanks!

Signed-off-by: Xuanwo <[email protected]>
@dantengsky dantengsky added this pull request to the merge queue Jan 6, 2025
Merged via the queue into databendlabs:main with commit 52794c1 Jan 6, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants