Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try split number cast function impl #17155

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jan 2, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

try to extract integer arithmetic logic from numeric-basic-arithmetic to new crate.

extract some logic from number_to_number

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 2, 2025
@TCeason TCeason marked this pull request as draft January 2, 2025 07:36
@TCeason TCeason force-pushed the split3 branch 2 times, most recently from bda0f2b to 7a7aa13 Compare January 2, 2025 10:14
@TCeason TCeason marked this pull request as ready for review January 2, 2025 11:41
@TCeason TCeason requested a review from sundy-li January 2, 2025 11:42
@TCeason
Copy link
Collaborator Author

TCeason commented Jan 3, 2025

in commit 2b500f3 we optimize div register. Now it's a beautiful graph.

image

@TCeason TCeason force-pushed the split3 branch 3 times, most recently from f0b6a58 to 59701ef Compare January 7, 2025 09:29
@TCeason TCeason marked this pull request as draft January 7, 2025 09:31
@TCeason TCeason force-pushed the split3 branch 2 times, most recently from 02d536d to 8c89170 Compare January 7, 2025 10:40
@TCeason TCeason marked this pull request as ready for review January 7, 2025 12:07
@TCeason
Copy link
Collaborator Author

TCeason commented Jan 7, 2025

Finally:

image

@TCeason
Copy link
Collaborator Author

TCeason commented Jan 7, 2025

cc @BohuTANG This pr can be merged.

@BohuTANG BohuTANG merged commit a2b69dd into databendlabs:main Jan 8, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants