Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): bump ast 0.1.3 #17145

Merged
merged 16 commits into from
Jan 1, 2025
Merged

chore(query): bump ast 0.1.3 #17145

merged 16 commits into from
Jan 1, 2025

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Dec 31, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. bump ast 0.1.2
  2. remove pretty statement
  3. forbidden lazy topn in window with QUALIFY
    fixes bug: explain ast does not handle parentheses correctly #16777 Lazy topn should be disabled in query with qualify #17146

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from b41sh December 31, 2024 06:18
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 31, 2024
@sundy-li sundy-li requested a review from forsaken628 December 31, 2024 06:18
@sundy-li sundy-li enabled auto-merge December 31, 2024 09:49
@sundy-li sundy-li changed the title chore(query): bump ast 0.1.2 chore(query): bump ast 0.1.3 Dec 31, 2024
@sundy-li sundy-li added this pull request to the merge queue Dec 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 31, 2024
@sundy-li sundy-li added this pull request to the merge queue Dec 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 31, 2024
@BohuTANG BohuTANG merged commit 0984b3f into databendlabs:main Jan 1, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: explain ast does not handle parentheses correctly
4 participants