-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tweak attach table refreshing #17019
Merged
BohuTANG
merged 8 commits into
databendlabs:main
from
dantengsky:chore-refact-attach-table-refresh
Dec 10, 2024
Merged
chore: tweak attach table refreshing #17019
BohuTANG
merged 8 commits into
databendlabs:main
from
dantengsky:chore-refact-attach-table-refresh
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
this PR only has small changes that no need to record, like coding styles.
label
Dec 9, 2024
dantengsky
changed the title
chore: refresh attach table refresh
chore: tweak attach table refreshing
Dec 9, 2024
11 tasks
dantengsky
force-pushed
the
chore-refact-attach-table-refresh
branch
from
December 9, 2024 11:30
6e63720
to
0129fbc
Compare
TCeason
reviewed
Dec 10, 2024
TCeason
approved these changes
Dec 10, 2024
Co-authored-by: TCeason <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Refactor Table Creator
Introduced an additional parameter to specify whether the table info should not be refreshed.
For attached tables, table info will not be refreshed if this parameter is set to
true
.PR fix: lock attach table's snapshot location #16952 introduces some unnecessary table info refreshments
With refactoring of this PR, data generation for system tables like
system.table
andsystem.columns
will not refresh table_info by defaultRemove
refresh_schema
fromFuseTable
refresh_table_info
.Tests
Type of change
This change is