Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak attach table refreshing #17019

Merged

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Dec 9, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Refactor Table Creator

    • Introduced an additional parameter to specify whether the table info should not be refreshed.

    • For attached tables, table info will not be refreshed if this parameter is set to true.

    • PR fix: lock attach table's snapshot location  #16952 introduces some unnecessary table info refreshments

      With refactoring of this PR, data generation for system tables like system.table and system.columns will not refresh table_info by default

  2. Remove refresh_schema from FuseTable

    • Collapsed into the new method refresh_table_info.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - use existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 9, 2024
@dantengsky dantengsky changed the title chore: refresh attach table refresh chore: tweak attach table refreshing Dec 9, 2024
@dantengsky dantengsky force-pushed the chore-refact-attach-table-refresh branch from 6e63720 to 0129fbc Compare December 9, 2024 11:30
@dantengsky dantengsky marked this pull request as ready for review December 10, 2024 04:01
@dantengsky dantengsky requested a review from TCeason December 10, 2024 04:01
@dantengsky dantengsky enabled auto-merge December 10, 2024 04:44
@dantengsky dantengsky added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@dantengsky dantengsky added this pull request to the merge queue Dec 10, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 10, 2024
@BohuTANG BohuTANG merged commit 603fbf0 into databendlabs:main Dec 10, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants