-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): add date_diff function #16560
Conversation
6e56eb2
to
3053fc0
Compare
tests/sqllogictests/suites/query/functions/02_0012_function_datetimes.test
Show resolved
Hide resolved
Sorry, I got you. But, what's the result of |
Oh, I just mean add a logic test case:
|
So what should I do is to fix it to be compatible with Snowflake and add more tests? |
Date diff about year just need to evaluate year sub. E.g. 2023-12-31 2024-01-01 just need to calc year sub. |
Ok, thank you.
TCeason ***@***.***> 于2024年10月8日周二 14:33写道:
… So what should I do is to fix it to be compatible with Snowflake and add
more tests?
Date diff about year just need to evaluate year sub. E.g.
2023-12-31 2024-01-01 just need to calc year sub.
—
Reply to this email directly, view it on GitHub
<#16560 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AL4OCSKJ7XXJNNZXDXK7I53Z2N4E7AVCNFSM6AAAAABPGYZISGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJYHE3DMNBQGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
06be419
to
df2d0fd
Compare
29a36d8
to
bb1d61c
Compare
dd1e9f1
to
663ae9f
Compare
tests/sqllogictests/suites/query/functions/02_0012_function_datetimes.test
Outdated
Show resolved
Hide resolved
8946d89
to
bfaff2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* support date and timestamp
476b8d1
to
5308b77
Compare
Hi @chagelo after approving this pr, I see you force-push a commit. What's diff in this commit? just rebase lastest main? |
Yes |
@soyeric128 Documentation need update. Thanks. |
@chagelo Thanks to your contribution! |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
related to #16534
Tests
Type of change
This change is