refactor: improve raft connection and logging filter #15801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only reuse a connection if there is no error returned from the last RPC. When a raft RPC is finished, push the connection back for next RPC if it returns an `Ok`. Otherwise it drops the connection and the next RPC will re-create a new one. Such approach ensures no problematic connection will be used. Support multi log prefix filter.
github-actions
bot
added
the
pr-refactor
andylokandy
reviewed
Jun 16, 2024
| } | ||
|
|
||
| fn match_prefix_many(meta: &Metadata, prefixes: &[String]) -> bool { | ||
| if is_severe(meta) { |
There was a problem hiding this comment.
No, warning and error logs are considered severe, is there better term for it?
There was a problem hiding this comment.
ok. I think it's fine.
lichuang
reviewed
Jun 16, 2024
| back_off_min_delay: Duration::from_secs(1), | ||
| back_off_max_delay: Duration::from_secs(60), | ||
| back_off_chances: 3, | ||
| back_off_ratio: 1.5, |
There was a problem hiding this comment.
are these params configuable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: improve raft connection and logging filter
Only reuse a connection if there is no error returned from the last RPC.
When a raft RPC is finished, push the connection back for next RPC if it
returns an
Ok. Otherwise it drops the connection and the next RPC willre-create a new one. Such approach ensures no problematic connection
will be used.
Support multi log prefix filter.
Tests
Type of change
Related Issues
This change is