Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dynamic enable of rust backtrace #15749

Merged
merged 10 commits into from
Jun 14, 2024

Conversation

dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Jun 6, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat: support dynamic enable of rust backtrace

SYSTEM ENABLE EXCEPTION_BACKTRACE;
SYSTEM DISABLE EXCEPTION_BACKTRACE;

close: #15468

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jun 6, 2024
@dqhl76 dqhl76 marked this pull request as ready for review June 6, 2024 15:32
@Xuanwo
Copy link
Member

Xuanwo commented Jun 6, 2024

Can we reuse existing stetement like set? Adding a new set enable/disable seems not cool.

@sundy-li
Copy link
Member

sundy-li commented Jun 7, 2024

maybe

system enable EXCEPTION_BACKTRACE

@BohuTANG

This comment was marked as resolved.

@zhang2014
Copy link
Member

Looks better to add a setting that are easily enabled on the Cloud, as I believe these settings are intended for us rather than for users.

Setting always set to tenant. We need admin API.

@dqhl76
Copy link
Collaborator Author

dqhl76 commented Jun 7, 2024

Thanks for reviews. I will keep the syntax and fix the missing boardcast problem.

@dqhl76 dqhl76 marked this pull request as draft June 7, 2024 01:14
@dqhl76 dqhl76 force-pushed the switch-backtrace branch from 0a0ae3d to 4b4088e Compare June 7, 2024 07:05
src/query/ast/src/parser/statement.rs Outdated Show resolved Hide resolved
@dqhl76 dqhl76 marked this pull request as ready for review June 12, 2024 06:24
@dqhl76 dqhl76 marked this pull request as draft June 13, 2024 08:34
@dqhl76 dqhl76 force-pushed the switch-backtrace branch from d056671 to ae016a7 Compare June 13, 2024 12:14
@dqhl76 dqhl76 marked this pull request as ready for review June 14, 2024 01:13
Signed-off-by: Liuqing Yue <[email protected]>
@dqhl76 dqhl76 enabled auto-merge June 14, 2024 01:54
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dqhl76 dqhl76 added this pull request to the merge queue Jun 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 14, 2024
@dqhl76 dqhl76 added this pull request to the merge queue Jun 14, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jun 14, 2024
@BohuTANG BohuTANG merged commit 7ea02db into databendlabs:main Jun 14, 2024
72 checks passed
@dqhl76 dqhl76 deleted the switch-backtrace branch June 26, 2024 02:29
@wubx
Copy link
Member

wubx commented Jun 27, 2024

@soyeric128 need doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: support dynamic enable of rust backtrace
6 participants