-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): delete len check in mget_database/table_names_by_ids #15640
Conversation
Docker Image for PR
|
In dev warehouse system:
In test warehouse show_grants it fixed: deploy@(show_grants)/default> select version();
SELECT
version()
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ version() │
│ String │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Databend Query v1.2.490-nightly-49fa83976d(rust-1.78.0-nightly-2024-05-25T11:22:38.392488593Z) │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
1 row read in 1.515 sec. Processed 1 row, 1B (0.66 row/s, 0B/s)
deploy@(show_grants)/default> show grants;
SHOW GRANTS
┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ privileges │ object_name │ object_id │ grant_to │ name │ grants │
│ String │ String │ Nullable(UInt64) │ String │ String │ Nullable(String) │
├────────────┼────────────────────┼──────────────────┼──────────┼────────┼─────────────────────────────────────────────────────────────┤
│ ALL │ *.* │ NULL │ USER │ deploy │ GRANT ALL ON *.* TO 'deploy'@'%' │
│ · │ · │ · │ · │ · │ · │
│ · │ · │ · │ · │ · │ · │
│ · │ · │ · │ · │ · │ · │
xxx │ │ │ │ │
│ (2 shown) │ │ │ │ │ │
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
31 rows read in 1.387 sec. Processed 31 rows, 4.52 KiB (22.36 rows/s, 3.26 KiB/s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TCeason)
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
delete some err check
Tests
Type of change
This change is