Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disk cache load refine and reduce the info flood logs #15576

Merged
merged 6 commits into from
May 20, 2024

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented May 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Add more unit test for cache restart load
  • Refactory the cache reload logic, make the parallel_scan both for reset&fuzzy
  • Spill disk_cache.rs into disk_cache dir
  • Add data_cache_key_reload_policy config description to query.toml
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label May 19, 2024
@BohuTANG BohuTANG requested a review from dantengsky May 20, 2024 04:05
@BohuTANG BohuTANG marked this pull request as ready for review May 20, 2024 04:05
Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos, others LGTM

src/query/storages/common/cache/Cargo.toml Outdated Show resolved Hide resolved
@BohuTANG BohuTANG merged commit b39b311 into databendlabs:main May 20, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants