fix: Avoid duplicate temp file name for install-snapshot requests #15565
+84
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves an issue where duplicate temporary file names were generated when two install-snapshot requests were received in close temporal proximity. This could potentially lead to conflicts and erroneous behavior during snapshot installation. Changes: - Added logic to generate unique temporary file names for each install-snapshot request to prevent naming conflicts. - Additionally, this commit enhances error handling by including context information in the `io::Error` returned from `SnapshotStoreV002`. This improvement aids in better understanding the source and nature of errors when they occur.
drmingdrmer
force-pushed
the
79-fix-snapshot
branch
from
e80fcf9 to
43c3d84
Compare
This was referenced Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
fix: Avoid duplicate temp file name for install-snapshot requests
This commit resolves an issue where duplicate temporary file names were
generated when two install-snapshot requests were received in close
temporal proximity. This could potentially lead to conflicts and
erroneous behavior during snapshot installation.
Changes:
Added logic to generate unique temporary file names for each
install-snapshot request to prevent naming conflicts.
Additionally, this commit enhances error handling by including context
information in the
io::Errorreturned fromSnapshotStoreV002. Thisimprovement aids in better understanding the source and nature of
errors when they occur.
Tests
Type of change
Related Issues
This change is