Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix group by cube with join panic assert #15515

Merged
merged 3 commits into from
May 14, 2024
Merged

fix: fix group by cube with join panic assert #15515

merged 3 commits into from
May 14, 2024

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented May 14, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix: fix group by bug

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label May 14, 2024
@lichuang lichuang requested a review from b41sh May 14, 2024 03:42
Copy link

what-the-diff bot commented May 14, 2024

PR Summary

  • New Test File Added
    A new test file named issue_14500.test has been incorporated into the tests/sqllogictests/suites/base/issues directory. This helps to improve the robustness of the project by increasing the range of tests it can perform.

  • Updated Assertion Statement in physical_aggregate_expand.rs
    The code within the physical_aggregate_expand.rs file was updated, specifically the assertion statement at line 55. This modification now allows the use of nullable data types which provides more flexibility in the system.

  • Expansion of output_fields Vector in physical_aggregate_expand.rs
    Another adjustment was made in the physical_aggregate_expand.rs file which involved adding a new field into the output_fields vector at line 56. This addition could potentially increase and aid the versatility of data handling within the program.

@lichuang lichuang changed the title fix: fix group by bug fix: fix group by bug, issue 14500 May 14, 2024
@BohuTANG BohuTANG changed the title fix: fix group by bug, issue 14500 fix: fix group by cube with join panic May 14, 2024
@BohuTANG BohuTANG changed the title fix: fix group by cube with join panic fix: fix group by cube with join panic assert May 14, 2024
@BohuTANG BohuTANG merged commit 5de4309 into databendlabs:main May 14, 2024
72 checks passed
@lichuang lichuang deleted the group_by_panic branch June 4, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: group by cube with join cause panic
3 participants