Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize vacuum drop table, execute in parallel #15478

Merged
merged 6 commits into from
May 11, 2024
Merged

feat: optimize vacuum drop table, execute in parallel #15478

merged 6 commits into from
May 11, 2024

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented May 11, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat: optimize vacuum drop table, execute in parallel

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@lichuang lichuang requested a review from dantengsky May 11, 2024 04:45
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label May 11, 2024
@dantengsky
Copy link
Member

besides:

the number of files returned might be slightly larger than dry_runt_limit. we either need to update the documentation accordingly or adjust the list of files that are returned (at the end of execution).

@dantengsky dantengsky enabled auto-merge May 11, 2024 11:17
@dantengsky dantengsky added this pull request to the merge queue May 11, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request May 11, 2024
@BohuTANG BohuTANG merged commit 6981624 into databendlabs:main May 11, 2024
72 checks passed
@lichuang lichuang deleted the vacuum_drop_table_optimize branch July 6, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants