Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ScalarVisitor refactor replace_predicate_column #15439

Merged
merged 1 commit into from
May 9, 2024
Merged

refactor: ScalarVisitor refactor replace_predicate_column #15439

merged 1 commit into from
May 9, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented May 8, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

use ScalarVisitor refactor ScalarExpr recursive

  • Fixes #[Link the issue here]

Tests

  • No Test - Need to provide all old tests passed.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label May 8, 2024
@TCeason TCeason marked this pull request as draft May 8, 2024 13:53
@TCeason TCeason force-pushed the visitor branch 4 times, most recently from 8234e56 to 6913e5e Compare May 9, 2024 03:13
@TCeason TCeason changed the title refactor: ScalarVisitor refactor replace_predicate_x refactor: ScalarVisitor refactor replace_predicate_column May 9, 2024
@TCeason TCeason marked this pull request as ready for review May 9, 2024 04:01
@TCeason TCeason requested review from b41sh, sundy-li and xudong963 May 9, 2024 04:02
@BohuTANG BohuTANG merged commit b232ff1 into databendlabs:main May 9, 2024
78 checks passed
This was referenced Jul 14, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 approved these changes

@sundy-li sundy-li sundy-li approved these changes

@b41sh b41sh Awaiting requested review from b41sh

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TCeason @sundy-li @xudong963 @BohuTANG