Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix array_concat function domain panic #15424

Merged
merged 1 commit into from
May 8, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented May 7, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Modify the domain calculation of array_concat, array_distinct, array_flatten functions to avoid generic type domain panic.
  • Reimplement array_prepend and array_append functions to support the case where the inner type is nullable.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested review from sundy-li and andylokandy May 7, 2024 12:04
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label May 7, 2024
@BohuTANG BohuTANG merged commit 29514e7 into databendlabs:main May 8, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: array_concat with column never returns
3 participants