refactor: separate key and value: add BackgroundTaskCreator
#15063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
29 tasks
`BackgroundJobIdent` is a kvapi::Key but not a value. It does not need to be `serde`. Thus in this commit we create another struct `BackgroundTaskCreator` with the same structure as `BackgroundJobIdent` for usage in values. And remove `serde` declaration from `BackgroundJobIdent`. - Part of databendlabs#14719
drmingdrmer
force-pushed
the
23-bg-job-ident
branch
from
000eb8c to
2b8650e
Compare
drmingdrmer
changed the title
BackgroundTaskCreatorBackgroundTaskCreator
youngsofun
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: add
BackgroundTaskCreatorBackgroundJobIdentis a kvapi::Key but not a value.It does not need to be
serde.Thus in this commit we create another struct
BackgroundTaskCreatorwith the same structure as
BackgroundJobIdentfor usage in values.And remove
serdedeclaration fromBackgroundJobIdent.Tests
Type of change
Related Issues