Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force attachment to use EmptyFieldAs::FieldDefault. #14767

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Feb 27, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

CSV attachment is mainly used in Drivers for insert.
In the future, client should use EmptyFieldAs=STRING or FieldDefault to distinguish NULL and empty string.
However, old servers ds not support missing_field_as, so client can not add the option directly at now.
So we will get empty_field_as = NULL, which will raise error if there is empty string for non-nullable string field.

remove this after

  1. the old server is no longer supported
  2. Driver add the option "EmptyFieldAs=FieldDefault"

related pr #14335

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun changed the title force attachment to use EmptyFieldAs::FieldDefault. fix: force attachment to use EmptyFieldAs::FieldDefault. Feb 27, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Feb 27, 2024
Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit e88992f into databendlabs:main Feb 27, 2024
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants