Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): refactor new group_agg and test #14742

Closed
wants to merge 5 commits into from
Closed

chore(query): refactor new group_agg and test #14742

wants to merge 5 commits into from

Conversation

Freejww
Copy link
Contributor

@Freejww Freejww commented Feb 26, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Refactor transform_partition_bucket in the new group_agg and test correctness in singleton..

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 26, 2024
@Freejww Freejww marked this pull request as draft February 26, 2024 12:06
@Freejww Freejww marked this pull request as ready for review February 27, 2024 03:02
sundy-li
sundy-li reviewed Feb 27, 2024
View reviewed changes
...ervice/src/pipelines/processors/transforms/aggregator/serde/transform_group_by_serializer.rs
DataBlock::new_from_columns(columns)
}

// pub struct SerializeGroupByStream<Method: HashMethodBounds> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't comment the old codes, just delete them if they are not used anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will delete old codes after new codes work.

@Freejww Freejww marked this pull request as draft February 27, 2024 06:03
@Freejww Freejww closed this Feb 27, 2024
@Freejww Freejww deleted the cluster_group_agg branch March 5, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li left review comments

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freejww @sundy-li