Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix count rewrite in agg index #14256

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Conversation

ariesdevil
Copy link
Contributor

@ariesdevil ariesdevil commented Jan 7, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

count(col) will be rewritten to count() if col is NOT nullable, as create agg index will rewrite statement and don't know the col's datatype, we will provide both count(col) and count() for agg index, make query rewrite with agg index happy.

Fixes #14249

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 7, 2024
@ariesdevil ariesdevil marked this pull request as ready for review January 7, 2024 11:08
@ariesdevil ariesdevil requested review from b41sh and sundy-li January 7, 2024 11:08
@BohuTANG BohuTANG merged commit 95a76f3 into databendlabs:main Jan 7, 2024
73 checks passed
@ariesdevil ariesdevil deleted the agg-index branch January 7, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aggregating index status issue
3 participants