-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(query): Rename table not allow modify catalog or database #14098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
this PR only has small changes that no need to record, like coding styles.
label
Dec 20, 2023
TCeason
force-pushed
the
rename_table
branch
from
December 20, 2023 11:00
f4f783d
to
6de203a
Compare
sundy-li
approved these changes
Dec 20, 2023
cc @wubx after this pr merge into main branch, Databend not support modify databend while execute sql |
andylokandy
reviewed
Dec 20, 2023
Comment on lines
+1001
to
1004
if new_catalog != catalog || new_database != database { | ||
return Err(ErrorCode::BadArguments( | ||
"alter catalog not allowed while rename table", | ||
"Rename table not allow modify catalog or database", | ||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if new_catalog != catalog || new_database != database { | |
return Err(ErrorCode::BadArguments( | |
"alter catalog not allowed while rename table", | |
"Rename table not allow modify catalog or database", | |
)); | |
if new_catalog != catalog || new_database != database { | |
return Err(ErrorCode::BadArguments( | |
"Rename table not allow modify catalog or database", | |
)) | |
.set_span(database.and_then(|ident| ident.span)); |
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 21, 2023
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 21, 2023
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 21, 2023
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 21, 2023
11 tasks
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 21, 2023
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 22, 2023
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 22, 2023
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 22, 2023
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 22, 2023
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 22, 2023
TCeason
referenced
this pull request
in TCeason/datafuse
Dec 22, 2023
BohuTANG
referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Rename table not allow modify catalog or database
It's no use to support this, It will cause other questions.
BTW alter table can also rename table, it also not support modify database.
Fixes #[Link the issue here]
Tests
Type of change
This change is