-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: handle error returned from resolve_data_source()
#14076
Conversation
71e4876
to
e7029e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @BohuTANG, @lichuang, and @xudong963)
src/query/sharing/src/share_endpoint.rs
line 150 at r2 (raw file):
share_name, e ))), }
A json decoding error should be considered as internal error IMHO. UnknownXXX
should be used only when an object does not exist, not when an object is damaged.
src/query/sql/src/planner/binder/table.rs
line 263 at r2 (raw file):
parent = bind_context.parent.as_mut(); } if e.code() == 1025 {
Use named const ErrorCode::UNKNOWN_TABLE
instead of integer.
Does it need to deal with other causing errors such as UnknownDatabase
? There are several other errors needs to be considered: WrongShare
, WrongShareObject
, UnknownTableId
cc @lichuang, how about opening a new PR to process here? |
@lichuang will open a new PR |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
handle error returned from
resolve_data_source()
Fixes #14070
Tests
Type of change
This change is