refactor: access KVMeta with methods instead of field #14013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
Make `KVMeta.expire_at` a private field for future refactoring. Update accessing to it with via methods. Several methods are added to `KVMeta` and `SeqValue`: - `eval_expire_at_ms()` evaluate and return a absolute expire time in millisecond. The returned value is set to `u64::MAX` if not expire is set. - `get_expire_at_ms()` return an `Option` of absolute expire time in millisecond.
drmingdrmer
force-pushed
the
39-expire-at
branch
from
0e0f62f to
99e5b09
Compare
ariesdevil
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: access KVMeta with methods instead of field
Make
KVMeta.expire_ata private field for future refactoring.Update accessing to it with via methods.
Several methods are added to
KVMetaandSeqValue:eval_expire_at_ms()evaluate and return a absolute expire time in millisecond. The returned value is set tou64::MAXif not expire is set.get_expire_at_ms()return anOptionof absolute expire time in millisecond.Changelog
Related Issues
This change is