Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): Support create/alter/drop/desc/show password policy #14012

Merged
merged 3 commits into from
Dec 20, 2023
Merged

feat(query): Support create/alter/drop/desc/show password policy #14012

merged 3 commits into from
Dec 20, 2023

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Dec 14, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Support create/alter/drop/desc/show password policy
  • Support set password policy when creating and altering user
  • Verify password according to password policy
  • Convert show-like pattern to lowercase to use case-insensitive pattern matching

part of #13994

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 14, 2023
@b41sh b41sh force-pushed the feat-password-policy branch from 443a32f to ad99f98 Compare December 19, 2023 05:57
@b41sh b41sh force-pushed the feat-password-policy branch from ad99f98 to d7a664e Compare December 19, 2023 11:28
@b41sh b41sh requested a review from sundy-li December 19, 2023 13:33
@b41sh b41sh marked this pull request as ready for review December 19, 2023 13:33
@b41sh b41sh requested a review from drmingdrmer as a code owner December 19, 2023 13:33
drmingdrmer
drmingdrmer approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 54 files at r1, all commit messages.
Reviewable status: 8 of 54 files reviewed, all discussions resolved (waiting on @sundy-li)

@b41sh b41sh added this pull request to the merge queue Dec 20, 2023
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 20, 2023
@BohuTANG BohuTANG merged commit 6ca39c9 into databendlabs:main Dec 20, 2023
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@drmingdrmer drmingdrmer drmingdrmer approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b41sh @drmingdrmer @sundy-li @BohuTANG